[Part 2] Display logs for client and server #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersodb
reviewed
Dec 3, 2024
| @@ -62,12 +62,6 @@ jobs: | |||
| uses: pypa/[email protected] | |||
| with: | |||
| virtual-environment: .venv/ | |||
| # Skipping 3 cryptography issues that can't be patched because of FL4Health | |||
for more information, see https://pre-commit.ci
This reverts commit 0fbc5da.
…oks"" This reverts commit a7956f3.
for more information, see https://pre-commit.ci
# Conflicts: # florist/tests/unit/api/routes/server/test_training.py
# Conflicts: # florist/app/jobs/details/page.tsx
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #130 +/- ##
==========================================
- Coverage 93.83% 88.97% -4.86%
==========================================
Files 24 24
Lines 2221 2341 +120
Branches 120 192 +72
==========================================
- Hits 2084 2083 -1
- Misses 137 258 +121 ☔ View full report in Codecov by Sentry. |
# Conflicts: # .github/workflows/static_code_checks.yaml
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Feature
Short Description
Clickup Ticket(s): https://app.clickup.com/t/8689qq767
Part 2: UI for displaying logs. Part 1: #128
Adding a link to the progress details section for both server and clients, which will open a modal that fetches and displays the logs (see screenshots below). The modal also has an option for refreshing the logs, which will trigger a refetch, and a download option, which will save the logs in a file and download it.
Tests Added
Fully unit tested.